Repository navigation
Make vpc.max.networks dynamic and return a useful error at the limit - #14373
Conversation
5d6ffb0 to
d95452e
Compare
|
I've changed direction on this PR. Per-account/domain values aren't needed: the cap exists to handle the technical limitation of the VR's NIC capacity which is the same for every tenant, and VPC tiers already count toward the account and domain guest network limits. |
Damans227
left a comment
There was a problem hiding this comment.
thanks @MitchDrage, keeping it global looks right. LGTM
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14373 +/- ##
============================================
+ Coverage 20.21% 20.72% +0.50%
- Complexity 20747 20765 +18
============================================
Files 6426 6049 -377
Lines 580181 547750 -32431
Branches 71033 73171 +2138
============================================
- Hits 117282 113517 -3765
+ Misses 450184 420927 -29257
- Partials 12715 13306 +591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19646 |
|
@blueorangutan test |
|
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-17319)
|
Drop account name from the max VPCs error Co-authored-by: Bernardo De Marco Gonçalves <bernardomg2004@gmail.com>
|
@blueorangutan package |
|
@RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 20037 |
|
@blueorangutan test |
|
@RosiKyu a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-17575)
|
RosiKyu
left a comment
There was a problem hiding this comment.
LGTM
Tested on a KVM lab (Oracle Linux 9, advanced zone), baseline 24.0 build first, then the PR packages (24.0.0-shapeblue22753), as a normal user, a domain admin and root admin.
- Before:
vpc.max.networksis not dynamic; raising it has no effect until a restart. At the limit a user gets HTTP 530 "Internal error executing command". - After the upgrade the setting is dynamic and the custom value set before the upgrade (4) is kept.
- At the limit, user and admin both get HTTP 431 "VPC qa14373-vpc-base has reached the maximum of 4 networks. Delete an unused network or contact your platform administrator to raise the limit."
- Raising or lowering the value applies straight away, without a restart. Lowering it below the current count keeps the existing tiers and refuses new ones.
- A domain admin can't change the setting;
abcis rejected. - Deleting a tier frees a slot; isolated networks outside a VPC are not affected; the value is kept after a restart.
Minor, not blocking: -1 and 0 are accepted; every new tier is then refused with "maximum of -1 networks". A minimum check could be a small follow-up.
Description
vpc.max.networksto be dynamic, so changes no longer need a restart.Messages:
Original (HTTP 530):
Internal error executing command, please contact your system administratorNumber of networks per VPC cannot surpass [3].New (HTTP 431, all users):
VPC web-prod has reached the maximum of 3 networks. Delete an unused network or contact your platform administrator to raise the limit.Closes #14372
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
N/A
How Has This Been Tested?
How did you try to break this feature and the system with this change?
servermodule test suite. All tests pass.